This repository has been archived by the owner on May 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently testing upgrade from 7.0.0-alpha1 version to 8.0.0-SNAPSHOT doesn't make sense. This test will be added back later in a more sensitive way.
This is required because Elasticsearch 8.x Docker image run as elasticsearch user instead of root user and the working directory inside the container created by `-w` is own by root with 755 permissions.
The errors for Logstash default tests are the same as with 7.9.0-SNAPSHOT image (see #661 (comment) and #663). Logstash OSS failing test is a transient error. We may still improve some documentation before merging. |
Conky5
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the new branching model, this PR bump
master
branch to tests8.0.0-SNAPSHOT
Docker images (next major release).This also drop compatibility with 6.x Elastic stack versions in master branch (cf 6.8 branch for 6.8 compatibility).