Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Disable service links to prevent very long startup times #542

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Disable service links to prevent very long startup times #542

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63427bd
Disable service links.
Jun 16, 2020
6d888b5
Make the disabling of service links configurable.
Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions elasticsearch/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,9 @@ spec:
{{- if .Values.imagePullSecrets }}
imagePullSecrets:
{{ toYaml .Values.imagePullSecrets | indent 8 }}
{{- end }}
{{- if semverCompare ">1.13" .Capabilities.KubeVersion.GitVersion }}
enableServiceLinks: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we still want it to be configurable and enabled by default in values.yamlin addition of the K8S version check:

Suggested change
enableServiceLinks: false
enableServiceLinks: {{ .Values.enableServiceLinks }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I made the value configurable and updated both values.yaml and README.md.

{{- end }}
initContainers:
{{- if .Values.sysctlInitContainer.enabled }}
Expand Down