Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Fix Mismatch Between Service Selector and Pod Labels when using Helm Aliases in Kibana #493

Merged
merged 4 commits into from
Mar 24, 2020

Conversation

jamoflaw
Copy link
Contributor

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

When using aliases to deploy Kibana twice in requirements.yaml ie:

dependencies:
  - name: kibana
    repository: "@elastic"
    version: 7.6.0
  - name: kibana
    repository: "@elastic"
    version: 7.6.0
    alias: kibana-2

Both instances of Kibana will deploy successfully, however the aliased version will be inaccessible as the selector on the service is configured to use the {{ .Chart.name }} value which in the case of the aliased chart is different.

This PR allows Kibana to be deployed with an alias in the requirements.yaml

I have added a test which proves this is a noop when deploying in its default state (ie without alias).

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@jamoflaw jamoflaw changed the title Fix Mismatch Between Service Selector and Pod Labels when using Helm Aliases Fix Mismatch Between Service Selector and Pod Labels when using Helm Aliases in Kibana Feb 22, 2020
@jmlrt jmlrt added the bug Something isn't working label Mar 6, 2020
@jamoflaw
Copy link
Contributor Author

jamoflaw commented Mar 9, 2020

Just to add I've been using this branch to test and push a version of Kibana which uses this alias and it works well

Am I missing anything from the PR? CLA is signed

@jmlrt
Copy link
Member

jmlrt commented Mar 19, 2020

jenkins test this please

@jamoflaw
Copy link
Contributor Author

I've updated the tests fixing the lint issues - running the lint-python target now returns no issues

@jmlrt
Copy link
Member

jmlrt commented Mar 19, 2020

jenkins test this please

@jamoflaw
Copy link
Contributor Author

Is the fail a bug in Jenkins? I can't quite see what has failed there, looks as though GKE is complaining about an older version of K8s?

@jmlrt
Copy link
Member

jmlrt commented Mar 19, 2020

It seems that GKE has dropped support of 1.13 so we need to drop tests on this version.
You'll need to rebase on master when #533 will be merged.

@jamoflaw
Copy link
Contributor Author

OK pulled in the master branch 👍

@jmlrt
Copy link
Member

jmlrt commented Mar 20, 2020

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for this PR 👍

@jmlrt jmlrt merged commit b25d48b into elastic:master Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants