Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[meta] format with black python scripts #475

Merged
merged 4 commits into from
Feb 11, 2020
Merged

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Feb 10, 2020

This PR is reformatting all python scripts using black and add black formating to CI.

Also add phony targets and help to Makefiles.

@jmlrt jmlrt added the enhancement New feature or request label Feb 10, 2020
@jmlrt jmlrt requested a review from a team February 10, 2020 10:56
#!/usr/local/bin/runbld
set -euo pipefail

make lint-python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the python dependencies need installed before this? Otherwise black might not be available I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, fixed in 8e0c169

@jmlrt jmlrt requested a review from Conky5 February 11, 2020 09:48
Copy link
Contributor

@Conky5 Conky5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmlrt
Copy link
Member Author

jmlrt commented Feb 11, 2020

jenkins test this please

@jmlrt jmlrt merged commit 712b310 into elastic:master Feb 11, 2020
@jmlrt jmlrt deleted the black-python branch February 11, 2020 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants