Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[kibana] Add posibility to re-define http code for health-check #405

Closed
wants to merge 1 commit into from
Closed

[kibana] Add posibility to re-define http code for health-check #405

wants to merge 1 commit into from

Conversation

SergK
Copy link
Contributor

@SergK SergK commented Dec 10, 2019

When using plugins which enable SSO for kibana http code is changed
from 200 to 301 since "healthCheckPath" is now under "protection".
This patch introduce new value: healthCheckHttpCode which can be
changed depending on deployment schema

Signed-off-by: Sergiy Kulanov sergey@kulanov.org.ua

  • [*] Chart version not bumped (the versions are all bumped and released at the same time)
  • [*] README.md updated with any new values or changes
  • [*] Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

When using plugins which enable SSO for kibana http code is changed
from 200 to 301 since "healthCheckPath" is now under "protection".
This patch introduce new value: healthCheckHttpCode which can be
changed depending on deployment schema

Signed-off-by: Sergiy Kulanov <sergey@kulanov.org.ua>
@jmlrt
Copy link
Member

jmlrt commented Dec 11, 2019

jenkins test this please

@SergK
Copy link
Contributor Author

SergK commented Jan 2, 2020

Hi @jmlrt, any chance to make this available in the next release? Thank you

@SergK
Copy link
Contributor Author

SergK commented Feb 6, 2020

Hi @jmlrt, do you have any ETA on merging this PR? I want to get rid off my fork :( and use upstream as much as possible,
Thank you!

@jmlrt jmlrt self-requested a review February 18, 2020 06:27
@jmlrt
Copy link
Member

jmlrt commented Apr 1, 2020

Hi @SergK,
Sorry for the very long delay, we wanted to find a different way to fix it and just merged #549 which allows redirections in readiness probe.
Could you check if that fixes your issue?

@SergK
Copy link
Contributor Author

SergK commented Apr 1, 2020

@jmlrt thank you, Works for me!

@SergK SergK closed this Apr 1, 2020
@jmlrt
Copy link
Member

jmlrt commented Apr 1, 2020

Great! Thank you for your work and for waiting so long.

@SergK SergK deleted the kibana_provide_additional_status_for_healthcheck branch April 1, 2020 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants