Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[metricbeat] add notice about breaking change #397

Merged
merged 1 commit into from
Dec 6, 2019
Merged

[metricbeat] add notice about breaking change #397

merged 1 commit into from
Dec 6, 2019

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Dec 6, 2019

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Fix #395

@jmlrt jmlrt added the bug Something isn't working label Dec 6, 2019
@jmlrt jmlrt requested review from Crazybus and a team December 6, 2019 14:32
@jmlrt jmlrt self-assigned this Dec 6, 2019
elasticdog
elasticdog approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@elasticdog elasticdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmlrt jmlrt merged commit 22fe3cd into elastic:master Dec 6, 2019
@jmlrt jmlrt deleted the metricbeat-breaking-change-warning branch December 6, 2019 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elasticdog elasticdog elasticdog approved these changes

@Crazybus Crazybus Awaiting requested review from Crazybus

Assignees

@jmlrt jmlrt

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[metricbeat] helm upgrade is failing from metricbeat 7.4.1 to 7.5.0
2 participants
@jmlrt @elasticdog