Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

7.4.1 release #340

Merged
merged 6 commits into from
Oct 23, 2019
Merged

7.4.1 release #340

merged 6 commits into from
Oct 23, 2019

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Oct 22, 2019

does what the tin say

@jmlrt jmlrt added the enhancement New feature or request label Oct 22, 2019
@jmlrt jmlrt self-assigned this Oct 22, 2019
@jmlrt jmlrt marked this pull request as ready for review October 23, 2019 14:44
@jmlrt
Copy link
Member Author

jmlrt commented Oct 23, 2019

jenkins test this please

CHANGELOG.md Outdated

* 7.4.1 as the default stack version
* 6.8.4 as 6.x tested version
* Helm 2.15.1 support in [#309](https://github.com/elastic/helm-charts/pull/338) [@jmlrt](https://github.com/jmlrt)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Helm 2.15.1 support in [#309](https://github.com/elastic/helm-charts/pull/338) [@jmlrt](https://github.com/jmlrt)
* Helm 2.15.1 support in [#338](https://github.com/elastic/helm-charts/pull/338) [@jmlrt](https://github.com/jmlrt)

CHANGELOG.md Outdated
@@ -1,5 +1,34 @@
# Changelog

## 7.4.1 - 2019/10/22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 7.4.1 - 2019/10/22
## 7.4.1 - 2019/10/23

mgreau
mgreau previously approved these changes Oct 23, 2019
Copy link
Member

@mgreau mgreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Conky5
Conky5 previously approved these changes Oct 23, 2019
Copy link
Contributor

@Conky5 Conky5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left comments on minor doc tweaks.

@jmlrt jmlrt requested review from Conky5 and mgreau October 23, 2019 14:56
@jmlrt
Copy link
Member Author

jmlrt commented Oct 23, 2019

fixed changelog and removed logstash files commited by mistake

CHANGELOG.md Outdated

* 7.4.1 as the default stack version
* 6.8.4 as 6.x tested version
* Helm 2.15.1 support in [#309](https://github.com/elastic/helm-charts/pull/309) [@jmlrt](https://github.com/jmlrt)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be #338 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sorry 🤦‍♂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries

Copy link
Contributor

@Conky5 Conky5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmlrt jmlrt merged commit fb24331 into elastic:master Oct 23, 2019
@jmlrt jmlrt deleted the 7.4.1 branch October 23, 2019 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants