Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[kibana] Allow configuring lifecycle events #295

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

karlbohlmark
Copy link
Contributor

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@karlbohlmark
Copy link
Contributor Author

Ok, I signed the CLA agreement now, do I need to do anything more with regards to that?

Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Crazybus
Copy link
Contributor

Ok, I signed the CLA agreement now, do I need to do anything more with regards to that?

Nope it looks good!

jenkins test this please

@Crazybus Crazybus merged commit de1e565 into elastic:master Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants