This repository has been archived by the owner on May 16, 2023. It is now read-only.
[elasticsearch] Drop version from chart label in service #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As identified in #284 having the version in the label would cause the service to be recreated during a chart version upgrade.
|
Does it mean that to migrate to the next chart version (7.4) it will be required to reinstall the chart? |
@tetianakravchenko Certainly not, and we will never purposefully bring in any breaking changes requiring a reinstall. We have an "upgrade" test as part of our automated testing pipeline https://github.com/elastic/helm-charts/blob/master/elasticsearch/examples/upgrade/Makefile to ensure that each releases remains backwards compatible with the initial 7.0.0 release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified in #284 having the version in the label would cause the
service to be recreated during a chart version upgrade.
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml