This repository has been archived by the owner on May 16, 2023. It is now read-only.
use same env variable as application #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riccardo Piccoli <riccardo.piccoli@softonic.com>
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test this please |
Crazybus
approved these changes
Sep 18, 2019
There was a problem hiding this comment.
LGTM!
What I don't understand is how the security example is still passing even though it is configured to use ELASTICSEARCH_USERNAME
helm-charts/kibana/examples/security/security.yml
Lines 5 to 15 in 82eb8e2
|
jenkins test this please |
|
jenkins test this please |
Crazybus
added a commit
that referenced
this pull request
Sep 18, 2019
If authentication wasn't configured correctly the Kibana readinessProbe would still pass since `curl --fail` doesn't consider a redirect to be a failure. If authentication fails Kibana would redirect you back to the login page so this readinessProbe always passed for security clusters. The tests are going to fail until #272 is merged and this PR has been rebased on top of it.
4 tasks
Crazybus
added a commit
that referenced
this pull request
Sep 19, 2019
If authentication wasn't configured correctly the Kibana readinessProbe would still pass since `curl --fail` doesn't consider a redirect to be a failure. If authentication fails Kibana would redirect you back to the login page so this readinessProbe always passed for security clusters. The tests are going to fail until #272 is merged and this PR has been rebased on top of it.
Crazybus
added a commit
that referenced
this pull request
Sep 19, 2019
If authentication wasn't configured correctly the Kibana readinessProbe would still pass since `curl --fail` doesn't consider a redirect to be a failure. If authentication fails Kibana would redirect you back to the login page so this readinessProbe always passed for security clusters. The tests are going to fail until #272 is merged and this PR has been rebased on top of it.
Crazybus
added a commit
that referenced
this pull request
Sep 19, 2019
If authentication wasn't configured correctly the Kibana readinessProbe would still pass since `curl --fail` doesn't consider a redirect to be a failure. If authentication fails Kibana would redirect you back to the login page so this readinessProbe always passed for security clusters. The tests are going to fail until #272 is merged and this PR has been rebased on top of it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Riccardo Piccoli riccardo.piccoli@softonic.com
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yamlIt appears that env vars used by kibana are
ELASTICSEARCH_USERNAMEandELASTICSEARCH_PASSWORD, but readiness usesELASTIC_USERNAMEandELASTIC_PASSWORD. This causes kibana to be unready, unless we also configureELASTIC_vars.