Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Hardening of the pod permissions. #265

Merged
merged 4 commits into from
Sep 19, 2019

Conversation

maximelenair
Copy link
Contributor

Following #232 - creating this pull request to add PSP / SA support for the chart.

I tried to keep a similar implementation to the one done in Filebeat - could be improved though.
Not sure if the integration tests need to be updated, I didn't really looked into it.

Permissions forr the PSP might be improved? Sadly due to the init container the permissions have to be quite large.

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@elasticcla
Copy link

Hi @maximelenair, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

Role, role binding and service account can now be created by the Helm chart.
An external service account can also be referenced.

Adding support for pod security policy to either be referenced from an existing one or created by the helm chart.
@olemarkus
Copy link

Anything in particular blocking this? We would appreciate getting this in so we can start using this chart.

Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Thanks for working on this :)

Just a few small tweaks and it is ready to go!

elasticsearch/README.md Outdated Show resolved Hide resolved
elasticsearch/README.md Outdated Show resolved Hide resolved
elasticsearch/tests/elasticsearch_test.py Outdated Show resolved Hide resolved
elasticsearch/tests/elasticsearch_test.py Outdated Show resolved Hide resolved
@Crazybus
Copy link
Contributor

jenkins test this please

Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much for working on this. This is great work and you added tests and everything too!

Sorry for the delays in getting around to reviewing it, I was on vacation. We are currently in the process of adding more maintainers to this project to make sure it doesn't go silent everytime I'm away :)

@Crazybus
Copy link
Contributor

jenkins test this please

@Crazybus
Copy link
Contributor

Tests are failing since this branch still has the now non-supported GKE versions in it. Will rebase on master...

@Crazybus
Copy link
Contributor

jenkins test this please

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants