Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Update priorityClassName default values in READMEs #250

Merged
merged 3 commits into from
Aug 7, 2019
Merged

Update priorityClassName default values in READMEs #250

merged 3 commits into from
Aug 7, 2019

Conversation

tanordheim
Copy link
Contributor

Updates READMEs for the elasticsearch, filebeat and kibana charts to clarify that the default value of priorityClassName is an empty string, re a discussion in #248.

I've made the change in one commit per chart, let me know if you'd rather want these squashed into a single commit.

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I've made the change in one commit per chart, let me know if you'd rather want these squashed into a single commit.

Nope this looks great!

Thank you for so quickly following up...it was almost too fast so I think you might be a robot ;)

@Crazybus Crazybus merged commit e724377 into elastic:master Aug 7, 2019
@tanordheim
Copy link
Contributor Author

Thank you for so quickly following up...it was almost too fast so I think you might be a robot ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants