Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Fixed indent on elasticsearch extraVolumes tpl. Was causing parsing errors. #245

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

d33vil
Copy link
Contributor

@d33vil d33vil commented Aug 2, 2019

Fixed indent on elasticsearch extraVolumes tpl. Was causing parsing errors.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@Crazybus
Copy link
Contributor

Crazybus commented Aug 7, 2019

Could you post what your configuration looks like for this? We have a test for this which passes with and without this indentation. In the YAML spec both should be and are valid so I would be interested to see what configuration you used to break this (as it might affect other values).

This is the test:

def test_adding_a_extra_volume_with_volume_mount():
config = '''
extraVolumes: |
- name: extras
emptyDir: {}
extraVolumeMounts: |
- name: extras
mountPath: /usr/share/extras
readOnly: true
'''
r = helm_template(config)
extraVolume = r['statefulset'][uname]['spec']['template']['spec']['volumes']
assert {'name': 'extras', 'emptyDir': {}} in extraVolume
extraVolumeMounts = r['statefulset'][uname]['spec']['template']['spec']['containers'][0]['volumeMounts']
assert {'name': 'extras', 'mountPath': '/usr/share/extras', 'readOnly': True} in extraVolumeMounts

@Crazybus
Copy link
Contributor

Crazybus commented Aug 7, 2019

jenkins test this please

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants