Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

publishNotReadyAddresses not working #237

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Conversation

MichaelSp
Copy link
Contributor

according to kubernetes/kubernetes#58662 the publishNotReadyAddresses: true is not working. Instead they suggest this annotation as workaround: service.alpha.kubernetes.io/tolerate-unready-endpoints: "true"

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

according to kubernetes/kubernetes#58662 the `publishNotReadyAddresses: true` is not working. Instead they suggest this annotation as workaround: `service.alpha.kubernetes.io/tolerate-unready-endpoints: "true"`
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@Crazybus
Copy link
Contributor

Which version of Kubernetes are you running? When we deprecated this option I checked to make sure that it was supported by 1.8 #123 (comment) and it was. However that issue you linked to makes it sound like this option was never properly implemented even though the changelog made it sound like it was. I'm curious to know which version you are running since I would hope that this fix was backported to the latest 1.8 release too.

jenkins test this please

@Crazybus
Copy link
Contributor

I confirmed that this is indeed broken on the latest 1.8 cluster running in minikube. 1.8 isn't part of the automated testing suite anymore since GKE no longer has the version available.

I'll make sure to manually test anything that could affect backwards compatibility for 1.8 from no on (instead of blindly trusting the changelogs).

Thank you for finding and fixing this!

@Crazybus Crazybus merged commit dd6447c into elastic:master Jul 30, 2019
@MichaelSp
Copy link
Contributor Author

MichaelSp commented Jul 30, 2019

I'm running v1.10.11 - thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants