Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[kibana] - Add additionals labels #225

Merged
merged 2 commits into from
Jul 19, 2019

Conversation

plumcraft
Copy link
Contributor

@plumcraft plumcraft commented Jul 17, 2019

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@plumcraft plumcraft force-pushed the add-kibana-additionals-labels branch from e3edaa1 to fc62de0 Compare July 17, 2019 15:53
@plumcraft
Copy link
Contributor Author

Hello, i'm not sure if i need to do something on my side ?

Thanks

@elasticcla
Copy link

Hi @plumcraft, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

Crazybus
Crazybus previously approved these changes Jul 18, 2019
Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Crazybus
Copy link
Contributor

@plumcraft The message from elasticcla describes what you need to do. Once you have added the email address you used in the commit just leave a new comment and it will re-run the cla check.

jenkins test this please

@plumcraft
Copy link
Contributor Author

plumcraft commented Jul 18, 2019

@Crazybus : thanks for your feedback, i've added my another email into my github profile, it should be fine now.

Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Crazybus
Copy link
Contributor

jenkins test this please

kibana/tests/kibana_test.py Outdated Show resolved Hide resolved
Co-Authored-By: Michael Russell <Crazybus@users.noreply.github.com>
@Crazybus
Copy link
Contributor

jenkins test this please

@Crazybus Crazybus merged commit 899c7d2 into elastic:master Jul 19, 2019
@Crazybus
Copy link
Contributor

Thank you for adding this in! Extra bonus points for adding a test too :)

@plumcraft plumcraft deleted the add-kibana-additionals-labels branch July 19, 2019 13:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants