Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[kibana] Update healthCheckPath to mention basePath usage #217

Merged
merged 3 commits into from
Jul 11, 2019

Conversation

Crazybus
Copy link
Contributor

@Crazybus Crazybus commented Jul 9, 2019

Make it clear that this setting needs to be updated if you are using a
custom basePath like in #216

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Make it clear that this setting needs to be updated if you are using a
custom basePath like in #216
@Crazybus Crazybus requested a review from tylerjl July 9, 2019 17:15
If you immediately export the result of a command it will never fail
even with `set -euo pipefail`
Co-Authored-By: Tyler Langlois <tylerjl@users.noreply.github.com>
@Crazybus Crazybus requested a review from tylerjl July 10, 2019 14:05
@Crazybus Crazybus merged commit 288e5f7 into master Jul 11, 2019
@Crazybus Crazybus deleted the a_healthy_base branch July 11, 2019 08:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants