Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] Fix pvc annotations with multiple fields #186

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

Crazybus
Copy link
Contributor

@Crazybus Crazybus commented Jun 24, 2019

Fixes: #183

This worked just fine if there was only 1 annotation being added. When
adding multiple annotations the extra whitespace was causing it to
break.

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Fixes: #183

This worked just fine if there was only 1 annotation being added. When
adding multiple annotations the extra whitespace was causing it to
break.
@Crazybus
Copy link
Contributor Author

jenkins test this please

@Crazybus
Copy link
Contributor Author

jenkins teSt tHis pLeAsE

@Crazybus Crazybus requested a review from jmlrt June 25, 2019 14:30
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Crazybus Crazybus merged commit 35e1b9d into master Jun 26, 2019
@Crazybus Crazybus deleted the so_persistent branch June 26, 2019 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[elasticsearch] Persistence annotations not working
2 participants