Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

change secretName field #182

Merged
merged 7 commits into from
Jul 1, 2019
Merged

change secretName field #182

merged 7 commits into from
Jul 1, 2019

Conversation

hxquangnhat
Copy link
Contributor

@hxquangnhat hxquangnhat commented Jun 21, 2019

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding this 🤦‍♂. We do actually have a test for it but unfortunately it uses the same name and secretName so the test doesn't catch this. Could you also update the test to use a different value for the secretName here:

def test_adding_a_secret_mount():
config = '''
secretMounts:
- name: elastic-certificates
secretName: elastic-certificates
path: /usr/share/filebeat/config/certs
'''

This bug also exists in the Kibana and Elasticsearch chart too btw! I'll open a separate PR to fix those charts unless you would like to add the changes here too.

filebeat/templates/daemonset.yaml Outdated Show resolved Hide resolved
Crazybus
Crazybus previously approved these changes Jun 24, 2019
Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for fixing up the tests and other charts too! 🙏

@Crazybus
Copy link
Contributor

jenkins test this please

@Crazybus
Copy link
Contributor

jenkins test this please

2 similar comments
@Crazybus
Copy link
Contributor

jenkins test this please

@Crazybus
Copy link
Contributor

Crazybus commented Jul 1, 2019

jenkins test this please

@Crazybus Crazybus merged commit 7c79ace into elastic:master Jul 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants