-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for finding this 🤦♂. We do actually have a test for it but unfortunately it uses the same name
and secretName
so the test doesn't catch this. Could you also update the test to use a different value for the secretName here:
helm-charts/filebeat/tests/filebeat_test.py
Lines 147 to 153 in 6f97893
def test_adding_a_secret_mount(): | |
config = ''' | |
secretMounts: | |
- name: elastic-certificates | |
secretName: elastic-certificates | |
path: /usr/share/filebeat/config/certs | |
''' |
This bug also exists in the Kibana and Elasticsearch chart too btw! I'll open a separate PR to fix those charts unless you would like to add the changes here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for fixing up the tests and other charts too! 🙏
jenkins test this please |
jenkins test this please |
2 similar comments
jenkins test this please |
jenkins test this please |
${CHART}/tests/*.py
${CHART}/examples/*/test/goss.yaml