Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] Run as 1000 #171

Merged
merged 1 commit into from
Jul 5, 2019
Merged

[elasticsearch] Run as 1000 #171

merged 1 commit into from
Jul 5, 2019

Conversation

naseemkullah
Copy link
Contributor

@naseemkullah naseemkullah commented Jun 17, 2019 •
edited
Loading

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@naseemkullah naseemkullah mentioned this pull request Jun 17, 2019
Closed
Crazybus
Crazybus suggested changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

You should only really tick these if you actually did them :P

elasticsearch/templates/statefulset.yaml Outdated Show resolved Hide resolved
@Crazybus
Copy link
Contributor

jenkins test this please

@naseemkullah naseemkullah force-pushed the elasticsearch-runasnonroot branch 2 times, most recently from 3c76657 to 6af3ab2 Compare June 19, 2019 00:09
Crazybus
Crazybus suggested changes Jun 21, 2019
View reviewed changes
elasticsearch/values.yaml Outdated Show resolved Hide resolved
elasticsearch/templates/statefulset.yaml Show resolved Hide resolved
@Crazybus Crazybus mentioned this pull request Jun 21, 2019
Closed
@naseemkullah naseemkullah force-pushed the elasticsearch-runasnonroot branch 3 times, most recently from e9b47cb to 08e6eee Compare June 21, 2019 12:29
Crazybus
Crazybus suggested changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small tweaks and then this one is ready to be merged too!

elasticsearch/values.yaml Outdated Show resolved Hide resolved
elasticsearch/templates/statefulset.yaml Show resolved Hide resolved
Crazybus
Crazybus approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Crazybus
Copy link
Contributor

Crazybus commented Jul 1, 2019

jenkins test this please

@Crazybus
Copy link
Contributor

Crazybus commented Jul 1, 2019

CI failure is coming from the linting test:

09:27:40 helm lint --strict ./
09:27:40 ==> Linting ./
09:27:40 [ERROR] templates/: render error in "elasticsearch/templates/statefulset.yaml": template: elasticsearch/templates/statefulset.yaml:53:22: executing "elasticsearch/templates/statefulset.yaml" at <.Values.fsGroup>: map has no entry for key "fsGroup"

Crazybus
Crazybus suggested changes Jul 1, 2019
View reviewed changes
elasticsearch/values.yaml Outdated Show resolved Hide resolved
@naseemkullah
Run as 1000
42c88fa 
Signed-off-by: Naseem <naseemkullah@gmail.com>
@Crazybus
Copy link
Contributor

Crazybus commented Jul 3, 2019

jenkins test this please

@naseemkullah
Copy link
Contributor Author

Seems like Jenkins nodes are offline? :)

Configuration elastic / helm-charts - pull-request - cluster creation » 1.12,docker&&virtual is still in the queue: All nodes of label ‘docker&&virtual’ are offline

@Crazybus
Copy link
Contributor

Crazybus commented Jul 5, 2019

Seems like Jenkins nodes are offline? :)

This is expected, a fresh VM is spun up for every build and is set offline so that it can't be re-used. The build failed because creating the test GKE cluster failed.

jenkins test this please

Crazybus
Crazybus approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for working on getting this in and tested!

@Crazybus Crazybus merged commit 51d3afd into elastic:master Jul 5, 2019
Crazybus added a commit that referenced this pull request Jul 5, 2019
@Crazybus
[elasticsearch] Adding testing for security context
a07e987 
Template tests for the changes from #171
@Crazybus Crazybus mentioned this pull request Jul 5, 2019
Merged
4 tasks
@naseemkullah
Copy link
Contributor Author

My pleasure!

@naseemkullah naseemkullah deleted the elasticsearch-runasnonroot branch July 5, 2019 12:09
Crazybus added a commit that referenced this pull request Jul 8, 2019
@Crazybus
[elasticsearch] Adding testing for security context
7dd1cc0 
Template tests for the changes from #171
Crazybus added a commit that referenced this pull request Jul 8, 2019
@Crazybus
[elasticsearch] Adding testing for security context
048be47 
Template tests for the changes from #171
Crazybus added a commit that referenced this pull request Jul 9, 2019
@Crazybus
[elasticsearch] Adding testing for security context
3cf9015 
Template tests for the changes from #171
Crazybus added a commit that referenced this pull request Jul 9, 2019
@Crazybus
[elasticsearch] Adding testing for security context
5586ddb 
Template tests for the changes from #171
@Crazybus Crazybus mentioned this pull request Sep 19, 2019
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Crazybus Crazybus Crazybus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naseemkullah @elasticmachine @Crazybus