Add SourceAddr and TLS metadata to lj.Batch #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add connection metadata to `lj.Batch`. This provides the source address of the connection and TLS metadata (like peer certification for mTLS).
andrewkroh
force-pushed
the
export-batch-conn
branch
from
e81b4cb
to
29b0133
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
|
andrewkroh
added
the
Team:Security-External Integrations
efd6
reviewed
Aug 15, 2022
| in *bufio.Reader | ||
| tlsState *tls.ConnectionState | ||
| remoteAddr string | ||
| buf []byte |
There was a problem hiding this comment.
If we are confident that it's nearly always the case that the buf is not grown beyond 64 bytes long, maybe make it be a slice of another [64]byte field?
There was a problem hiding this comment.
I'm not confident on this so I'm going to leave it as is. But good idea.
efd6
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add connection metadata to
lj.Batch. This provides the source addressof the connection and TLS metadata (like peer certification for mTLS).