Skip to content

github-action: add catalog-validate for GitHub actions #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025

Conversation

v1v
Copy link
Member

@v1v v1v commented May 6, 2025

Details

⚠️ This PR was created by an automated tool. Please review the changes carefully. ⚠️

We want to enable the Catalog Info validation using GitHub actions.

Why

We want to make sure that the catalog-info file is valid and does not break the Catalog Ecosystem.

If there are any questions, please reach out to the @elastic/observablt-ci

Further details

Requires elastic/oblt-actions#272

Tasks

@v1v v1v requested a review from a team as a code owner May 6, 2025 16:40
@v1v v1v self-assigned this May 6, 2025
@v1v v1v requested review from kaanyalti and andrzej-stencel May 6, 2025 16:40
@pkoutsovasilis
Copy link

@v1v I see this error. This reminds me the recent issues we had with the VM images, wdyt, could it be that?

@v1v v1v requested a review from oakrizan May 7, 2025 08:22
@v1v
Copy link
Member Author

v1v commented May 7, 2025

@v1v I see this error. This reminds me the recent issues we had with the VM images, wdyt, could it be that?

Error: failed to run "go-licence-detector -rules dev-tools/templates/notice/rules.json -noticeTemplate dev-tools/templates/notice/NOTICE.txt.tmpl -noticeOut NOTICE.txt -in /tmp/depsout1476367232 -includeIndirect -overrides dev-tools/templates/notice/overrides.json: exec: "go-licence-detector": executable file not found in $PATH"

I'm not much familiar with the current implementation, never touched this BK pipeline or project. It looks like it's related:

I know @oakrizan is working on solving this issue for the long run.

I'd say to pin the version as we did in the past. @oakrizan , do you mind doing it? 🙏

@v1v v1v enabled auto-merge (squash) May 7, 2025 08:58
@v1v
Copy link
Member Author

v1v commented May 7, 2025

@pkoutsovasilis , #25 should fix the issue with the CI runners, in addition, to speed up builds, reducing the maintenance of CI runners. Let me know what you think.

@v1v v1v requested a review from a team as a code owner May 19, 2025 17:30
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label May 20, 2025
@v1v v1v disabled auto-merge May 20, 2025 13:40
@v1v v1v merged commit 0c41fc1 into main May 20, 2025
8 checks passed
@v1v v1v deleted the gh-oblt/add-catalog-validate branch May 20, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants