Skip to content

esutil: Modify the BulkIndexerConfig.Client type to esapi.Transport #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

esutil: Modify the BulkIndexerConfig.Client type to esapi.Transport #957

merged 1 commit into from
Apr 17, 2025

Conversation

zaneli
Copy link
Contributor

@zaneli zaneli commented Feb 24, 2025

Now, when using a pre-declared TypedClient, a separate Client instance had to be created via NewClient to pass it to BulkIndexerConfig.

To improve usability, this change updates the type of BulkIndexerConfig.Client to esapi.Transport, allowing both Client and TypedClient to be passed directly.

@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Feb 24, 2025 •
edited
Loading

💚 CLA has been signed

@zaneli zaneli marked this pull request as draft February 24, 2025 14:42
@zaneli zaneli marked this pull request as ready for review February 24, 2025 14:43
Anaethelion
Anaethelion approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for raising this.

@Anaethelion Anaethelion merged commit a2fc00c into elastic:main Apr 17, 2025
4 checks passed
This was referenced Apr 17, 2025
Closed
Closed
Anaethelion pushed a commit that referenced this pull request Apr 17, 2025
@zaneli @Anaethelion
esutil: Modify the BulkIndexerConfig.Client type to `esapi.Transpor…
eacf9e5 
…t` (#957)
Anaethelion pushed a commit that referenced this pull request Apr 17, 2025
@zaneli @Anaethelion
esutil: Modify the BulkIndexerConfig.Client type to `esapi.Transpor…
fa38e41 
…t` (#957)
Anaethelion pushed a commit that referenced this pull request Apr 17, 2025
@zaneli @Anaethelion
esutil: Modify the BulkIndexerConfig.Client type to `esapi.Transpor…
0620113 
…t` (#957)
This was referenced Apr 17, 2025
Merged
Merged
Merged
Anaethelion added a commit that referenced this pull request Apr 17, 2025
@Anaethelion @zaneli
esutil: Modify the BulkIndexerConfig.Client type to `esapi.Transpor…
1fb0573 
…t` (#957) (#998)

Co-authored-by: Shunsuke Otani <shun.otani@gmail.com>
Anaethelion added a commit that referenced this pull request Apr 17, 2025
@Anaethelion @zaneli
esutil: Modify the BulkIndexerConfig.Client type to `esapi.Transpor…
3283832 
…t` (#957) (#1000)

Co-authored-by: Shunsuke Otani <shun.otani@gmail.com>
Anaethelion added a commit that referenced this pull request Apr 17, 2025
@Anaethelion @zaneli
esutil: Modify the BulkIndexerConfig.Client type to `esapi.Transpor…
8c9c309 
…t` (#957) (#999)

Co-authored-by: Shunsuke Otani <shun.otani@gmail.com>
@zaneli zaneli deleted the feature/bulk_indexer_client branch April 18, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anaethelion Anaethelion Anaethelion approved these changes

Assignees
No one assigned
Labels
backport 8.18 backport 8.19 backport 9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaneli @Anaethelion