-
Notifications
You must be signed in to change notification settings - Fork 17
Failure Store: Update go-docappender to respect failure store status #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one question
One more question, sorry: should we be measuring "not_enabled" too? |
Agree, this metric could be useful too. Updated to expose it in the last commit. |
…ocappender into response_failure_store_support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good overall, just one small question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR updates go-docappender to respect new failure store response status and emit new correspodning metrics accordingly. The old "indexed" metrics stay intact instead a new separate set of failure store labels is exposed.
This PR depends on changes made for
BulkIndexerResponseItem
in elastic/go-elasticsearch#948 and should only be merged afterwards.How to test:
Use an instance of ES that has failure store feature enabled and enable failure store for a data stream via component template with.
Set a custom "fail" ingest pipeline with.
Ingest some data to corresponding data stream, then check that failure store metrics are getting reported correctly.
To emulate "failed" status, set backing data stream index to be read only with.