[8.x](backport #3986) Add timeout to bulker flush, add default case in failQueue #4172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* use poll timeout in es ctx * Add some SCALEDEBUG logs * add agent id to logs * debug logs in fleet.go * add default case, log deadline * 5m timeout * cleanup logs, move deadline to doFlush * move timeout before doFlush * cleanup logs * extracted const * remove log * exit bulker on checkin error * update to latest stack snapshot * revert break LOOP * move deadline inside doFlush * fix cancel * remove doFlush param * separate context * added changelog --------- Co-authored-by: Jill Guyonnet <jill.guyonnet@gmail.com> (cherry picked from commit 6b29ab4)
|
|
This pull request has not been merged yet. Could you please review and merge it @juliaElastic? 🙏 |
jlind23
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
Scale tests are often blocked at flushing the bulker queue.
How does this PR solve the problem?
Adding a context timeout to the bulker flush so it times out if it takes more time than the deadline.
How to test this PR locally
Ran scale tests here: https://buildkite.com/elastic/observability-perf/builds?branch=increase-poll-action-retries-for-agent-upgrades
Design Checklist
Checklist
./changelog/fragmentsusing the changelog toolRelated issues
Relates https://github.com/elastic/ingest-dev/issues/3783
This is an automatic backport of pull request #3986 done by Mergify.