Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action APM metadata #2472

Merged
merged 11 commits into from
Apr 13, 2023
Merged

Add action APM metadata #2472

merged 11 commits into from
Apr 13, 2023

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Apr 5, 2023

What is the problem this PR solves?

Help debugging agent actions.

How does this PR solve the problem?

Adding APM metadata to actions, see #1794

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@juliaElastic juliaElastic self-assigned this Apr 5, 2023
@juliaElastic juliaElastic requested review from a team as code owners April 5, 2023 13:00
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 5, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-12T14:46:16.837+0000

  • Duration: 17 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 678
Skipped 1
Total 679

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@juliaElastic juliaElastic mentioned this pull request Apr 5, 2023
5 tasks
@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2023

This pull request is now in conflicts. Could you fix it @juliaElastic? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b action-trace upstream/action-trace
git merge upstream/main
git push upstream action-trace

@mergify
Copy link
Contributor

mergify bot commented Apr 12, 2023

This pull request is now in conflicts. Could you fix it @juliaElastic? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b action-trace upstream/action-trace
git merge upstream/main
git push upstream action-trace

@juliaElastic
Copy link
Contributor Author

Hi! Can I get a review on this?

@juliaElastic juliaElastic merged commit 7c28955 into elastic:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants