User is able to create agent tags with more than 20 characters through enroll command.

[amolnater-qasource]

Kibana version: 8.4 BC-2 Kibana cloud environment

Host OS and Browser version: All, All

Build details:

VERSION: 8.4.0
BUILD: 55166
COMMIT: 9e9e0d6a685cbc2858a85a357f93dcb76259fdee

Preconditions:

1. 8.4 BC2 Kibana cloud environment should be available.

Steps to reproduce:

1. Login to Kibana environment.
2. Install an agent with say --tag= abcabcabcabcabcabcabcabcabcabc1234567890 (More than 20 characters.)
3. Observe user is able to create tag with more than 20 characters.

Expected Result:
As per PR elastic/kibana#136019 (comment) it is expected that tag name should be limited to 20 characters.

Screenshots:

[amolnater-qasource]

@manishgupta-qasource Please review.

[manishgupta-qasource]

Secondary review for this ticket is Done

[amolnater-qasource]

Hi Team,

We have revalidated this issue on latest 8.10.0 SNAPSHOT kibana cloud environment and found it still reproducible.

Observations:

• User is able to create agent tags with more than 20 characters tags with install command.

Screenshot:

Build details:
VERSION: 8.10.0 SNAPSHOT
BUILD: 65561
COMMIT: 4dadcbb91136a3e7d39e4b419aa12e21a37e4918

Please let us know if anything else is required from our end.

Thanks!

[pierrehilbert]

As this sanitize is done at Kibana level, should be assigned to Fleet Team @jen-huang / @kpollich

[jlind23]

@pierrehilbert tags are supplied at the enrolment. Not sure Elastic Agent prevents you from using more than 20chars.. The only option for Kibana would be to truncate these tags then..

[pierrehilbert]

Yes, that's the part of the code @juliaElastic wrote and @amolnater-qasource mentioned.
Will probably be better to have this check during enrollment but still a problem with the Sanitize function currently in place.

[jen-huang]

I'm moving this to fleet server. The sanitization code referenced is on Kibana send when tags are added/modified through UI, not adding during enrollment. We should have same set of sanitization on fleet server.