This repository was archived by the owner on Jan 10, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Companion Jupyter notebook for ML Classification Analytics #280
Merged
gingerwizard
merged 8 commits into
elastic:master
from
Winterflower:ml-classification-notebook
Dec 17, 2019
Merged
Companion Jupyter notebook for ML Classification Analytics #280
gingerwizard
merged 8 commits into
elastic:master
from
Winterflower:ml-classification-notebook
Dec 17, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaklaybul
suggested changes
Dec 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! I left a few small comments. I think it might also be worth including some diagrams that show the predicted values against some key features, perhaps one of origin/dest airport, origin/dest weather, or airline to demonstrate that this classification model might help someone predict the status of their next flight!
Machine Learning/Analytics Jupyter Notebooks/ml-analytics-classification.ipynb
Show resolved
Hide resolved
Machine Learning/Analytics Jupyter Notebooks/ml-analytics-classification.ipynb
Show resolved
Hide resolved
Machine Learning/Analytics Jupyter Notebooks/ml-analytics-classification.ipynb
Outdated
Show resolved
Hide resolved
viglia
approved these changes
Dec 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I second Michael's comment on explaining Apart from that it looks good |
gingerwizard
approved these changes
Dec 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.