Skip to content

[Illustrations] Fix SVG filenames and scope exports in docs demo#9796

Open
ryankeairns wants to merge 3 commits into
mainfrom
rk/cleanup-illustration-names
Open

[Illustrations] Fix SVG filenames and scope exports in docs demo#9796
ryankeairns wants to merge 3 commits into
mainfrom
rk/cleanup-illustration-names

Conversation

@ryankeairns

Copy link
Copy Markdown
Contributor

Summary

  • Fixes a typo in the professional-trophy svg file name
  • Changes a few file names for consistency in the naming pattern
  • Changes the docs example to scope all illustrations (this could be further improved with a debounce)

Screenshots

Example: change from dashboard to certificate
CleanShot 2026-07-09 at 10 17 20@2x

Impact Assessment

Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.

  • 🔴 Breaking changes — What will break? How many usages in Kibana/Cloud UI are impacted?
  • 💅 Visual changes — May impact style overrides; could require visual testing. Explain and estimate impact.
  • 🧪 Test impact — May break functional or snapshot tests (e.g., HTML structure, class names, default values).
  • 🔧 Hard to integrate — If changes require substantial updates to Kibana, please stage the changes and link them here.

Impact level: 🟢 None / 🟢 Low / 🟡 Moderate / 🔴 High

Release Readiness

  • Documentation: {link to docs page(s)}
  • Figma: {link to Figma or issue}
  • Migration guide: {steps or link, for breaking/visual changes or deprecations}
  • Adoption plan (new features): {link to issue/doc or outline who will integrate this and where}

QA instructions for reviewer

Checklist before marking Ready for Review

Reviewer checklist

  • Approved Impact Assessment — Acceptable to merge given the consumer impact.
  • Approved Release Readiness — Docs, Figma, and migration info are sufficient to ship.

Co-authored-by: Cursor <cursoragent@cursor.com>
@ryankeairns ryankeairns requested a review from a team as a code owner July 9, 2026 17:18
Copilot AI review requested due to automatic review settings July 9, 2026 17:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the illustrations catalog and website documentation by renaming/adding SVG assets in @elastic/eui-illustrations and adjusting the docs demo to have access to all illustration exports.

Changes:

  • Fixes/normalizes illustration SVG filenames (notably professional-trpohyprofessional-trophy).
  • Adds several new illustration SVG pairs (light/dark variants).
  • Updates the illustrations docs demo to scope all @elastic/eui-illustrations exports.

Reviewed changes

Copilot reviewed 1 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/website/docs/components/display/illustrations/index.mdx Imports all illustrations into the Demo scope so the example doesn’t need manual scope updates per illustration.
packages/illustrations/src/svgs/user-presentation-light-bulb.light.svg Adds a new light-mode SVG asset.
packages/illustrations/src/svgs/user-presentation-light-bulb.dark.svg Adds a new dark-mode SVG asset.
packages/illustrations/src/svgs/professional-trpohy.light.svg Removes the old (typo’d) light-mode SVG filename.
packages/illustrations/src/svgs/professional-trpohy.dark.svg Removes the old (typo’d) dark-mode SVG filename.
packages/illustrations/src/svgs/professional-trophy.light.svg Adds the corrected light-mode SVG filename for the professional trophy illustration.
packages/illustrations/src/svgs/professional-trophy.dark.svg Adds the corrected dark-mode SVG filename for the professional trophy illustration.
packages/illustrations/src/svgs/open-source-ai.light.svg Adds a new light-mode SVG asset.
packages/illustrations/src/svgs/open-source-ai.dark.svg Adds a new dark-mode SVG asset.
packages/illustrations/src/svgs/monitoring-logs.light.svg Adds a new light-mode SVG asset.
packages/illustrations/src/svgs/monitoring-logs.dark.svg Adds a new dark-mode SVG asset.
packages/illustrations/src/svgs/inline-assistance.light.svg Adds a new light-mode SVG asset.
packages/illustrations/src/svgs/inline-assistance.dark.svg Adds a new dark-mode SVG asset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/website/docs/components/display/illustrations/index.mdx Outdated
Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 14 changed files in this pull request and generated no new comments.

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants