Skip to content

Conversation

@alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Nov 3, 2025

Summary

Ensure EuiInMemoryTable, EuiBasicTable have a tableCaption property for accessibility.

Why are we making this change?

For accessibility (a11y) reasons, we need to ensure that EuiInMemoryTable,EuiBasicTable include the tableCaption prop:

<EuiBasicTable tableCaption="Descriptive caption for the table" ... />

The tableCaption provides context about the purpose or state of the entire table, helping screen reader users better understand its content. Additionally, this value is used to provide context for the Table -> Pagination component.

Tests

image

@alexwizp alexwizp changed the title [@elastic/eslint-plugin-eui] added new require-table-caption rule. [@elastic/eslint-plugin-eui] added new require-table-caption rule. Nov 3, 2025
@alexwizp alexwizp marked this pull request as ready for review November 3, 2025 12:37
@alexwizp alexwizp requested a review from a team as a code owner November 3, 2025 12:37
@weronikaolejniczak weronikaolejniczak self-requested a review November 3, 2025 15:46
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, @alexwizp! I can confirm the tests are passing. Just one nit.

Co-authored-by: Weronika Olejniczak <32842468+weronikaolejniczak@users.noreply.github.com>
Co-authored-by: Weronika Olejniczak <32842468+weronikaolejniczak@users.noreply.github.com>
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patience 😅 LGTM now! 🟢

@alexwizp alexwizp enabled auto-merge (squash) November 4, 2025 12:12
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@alexwizp alexwizp merged commit 4b095d3 into elastic:main Nov 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants