-
Notifications
You must be signed in to change notification settings - Fork 861
feat(eui): add repositionOnScroll to componentDefaults #9152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eui): add repositionOnScroll to componentDefaults #9152
Conversation
24361f9 to
f95d46b
Compare
f95d46b to
0664662
Compare
0664662 to
3fa4cf7
Compare
3fa4cf7 to
b158a7e
Compare
|
I tested the change in Kibana, and it seems to be working well! 👍 |
|
@mgadewoll ready for re-review 🙏🏻 |
|
@mgadewoll thank you for all the suggestions to make the implementation cleaner and improve test quality 🙏🏻 I applied all of them and I re-tested but I'd appreciate a test from you as well. Let me know if you have any more thoughts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 The changes LGTM and the usage in popover and tooltip work as expected. Nice work! 🎉
⏰ Friendly reminder to revert the test commits.
2db21e8 to
9594536
Compare
9594536 to
2ed993e
Compare
💚 Build SucceededHistory
|
💚 Build Succeeded
History
|
Summary
Add both
EuiPopoverandEuiToolTip'srepositionOnScrolltocomponentDefaults.Why are we making this change?
Resolves #8984
We are making this change for the grid layout initiative in Kibana.
See more details here: elastic/kibana#240882
Screenshots #
EuiPopover
Kapture.2025-10-27.at.18.01.06.mp4
EuiToolTip
Kapture.2025-10-27.at.18.50.02.mp4
Impact to users
🟢 This is not a breaking change. It's an enhancement.
QA
Specific checklist
EuiPopoverreposition on scroll works as expected in the testing storyEuiToolTipreposition on scroll works as expected in the testing storyGeneral checklist
Checked in both light and dark modesChecked in both MacOS and Windows high contrast modesChecked in mobile, Edge, and FirefoxChecked for accessibility including keyboard-only and screenreader modesProps have proper autodocs (using@defaultif default values are missing) and playground togglesChecked Code Sandbox works for any docs examplesUpdated visual regression testsIf applicable, added the breaking change issue label (and filled out the breaking change checklist)If the changes unblock an issue in a different repo, smoke tested carefully (see Testing EUI features in Kibana ahead of time)If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)