[EuiSelectableListItem] fix duplicated announcement for checked options #9028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Optional CSS class(es) to apply to the outermost element of the component. | ||
| * This allows for custom styling or theming. | ||
| */ |
There was a problem hiding this comment.
Thanks for adding these JSDoc 🙌🏻
| css={cssStyles} | ||
| tabIndex={tabIndex} | ||
| role="img" | ||
| role={isAriaHidden ? undefined : 'img'} |
There was a problem hiding this comment.
❌ NVDA + Firefox (duplicated announcement)
Kapture.2025-09-19.at.12.05.24.mp4
❌ NVDA + Chrome (duplicated announcement, label missing)
Kapture.2025-09-19.at.12.09.02.mp4
I checked how it works in production now as well:
NVDA + Firefox (duplicated label and "Checked" announcement, but label present and the screen reader only text is not duplicated)
Kapture.2025-09-19.at.12.13.04.mp4
The reported issues state that the label is repeated twice and the fact that it is "checked" is repeated twice. Now, the label is not repeated but the screen reader only text is.
I was testing this story.
Co-authored-by: Weronika Olejniczak <32842468+weronikaolejniczak@users.noreply.github.com>
|
@weronikaolejniczak moved to Draft, will retest |
💚 Build SucceededHistory
|
💔 Build Failed
Failed CI StepsHistory
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: elastic/kibana#219496
Closes: elastic/kibana#216048
Closes: elastic/kibana#219342
Closes: elastic/kibana#216157
Closes: elastic/kibana#217137
Closes: elastic/kibana#217456
Closes: elastic/kibana#218397
Closes: elastic/kibana#225240
Summary
This PR addresses an accessibility issue in the
EuiSelectableListItemcomponent where screen readers would announce checked options multiple times due to duplicated or misplaced screen reader text. The main changes include:aria-describedbyto each list item that references only the relevant screen reader description (previously set within the list item content).EuiScreenReaderOnlycomponent to accept a custom id prop, enabling proper linkage with accessibility attributes.EuiIconcomponent to correct an incorrect role attribute when aria-hidden is set to true.Impact to users
🟢 There are no updates required by consumers.
QA
General checklist
Added documentationProps have proper autodocs (using@defaultif default values are missing) and playground togglesChecked Code Sandbox works for any docs examplesIf applicable, added the breaking change issue label (and filled out the breaking change checklist)If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)