Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing styles for euiKeyPadMenu #8294

Merged
merged 10 commits into from
Feb 11, 2025
Merged

Fixing styles for euiKeyPadMenu #8294

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f7a4139
Style changes
ek-so Jan 26, 2025
351b99a
Simplify code for focused state (selected item) in Borealis
ek-so Jan 26, 2025
382d895
Prettier
ek-so Jan 27, 2025
900dc3a
Update key_pad_menu_item.styles.ts
ek-so Jan 27, 2025
eb1837f
Update key_pad_menu_item.styles.ts
ek-so Jan 27, 2025
ed3123e
Changelog
ek-so Jan 27, 2025
aa8a408
Delete 8294.md
ek-so Feb 10, 2025
24b83b0
Fixes
ek-so Feb 10, 2025
fc81fe0
Merge branch 'eui-theme/borealis' into key-pad-menu-styles
ek-so Feb 10, 2025
526043c
Fixes
ek-so Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixes
  • Loading branch information
@ek-so
ek-so committed Feb 10, 2025
commit 526043c2971342491af3f168b4db3b87fb23e9dd
20 changes: 10 additions & 10 deletions packages/eui/src/components/key_pad_menu/key_pad_menu_item.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,16 @@ export const euiKeyPadMenuItemStyles = (euiThemeContext: UseEuiTheme) => {
cursor: pointer;
text-decoration: underline;

${hasVisColorAdjustment
? focusTransformStyles
: `background-color: ${euiTheme.colors.backgroundBaseInteractiveHover}`}
${hasVisColorAdjustment
mgadewoll marked this conversation as resolved.
Show resolved Hide resolved
? focusTransformStyles
: `background-color: ${euiTheme.colors.backgroundBaseInteractiveHover}`}
}

&:focus {
box-shadow: none;
background-color: ${hasVisColorAdjustment
? euiTheme.focus.backgroundColor
: euiTheme.colors.backgroundBaseInteractiveHover
};
? euiTheme.focus.backgroundColor
: euiTheme.colors.backgroundBaseInteractiveHover};
}
`,
selected: css`
Expand All @@ -80,8 +79,8 @@ export const euiKeyPadMenuItemStyles = (euiThemeContext: UseEuiTheme) => {
&:focus-within {
color: ${euiTheme.colors.textPrimary};
background-color: ${!hasVisColorAdjustment
? euiTheme.colors.backgroundBaseInteractiveSelect
: ''};
? euiTheme.colors.backgroundBaseInteractiveSelect
: ''};
}
`,
disabled: {
Expand All @@ -91,16 +90,17 @@ export const euiKeyPadMenuItemStyles = (euiThemeContext: UseEuiTheme) => {

.euiKeyPadMenuItem__icon {
filter: ${hasVisColorAdjustment ? 'grayscale(100%)' : ''};

svg * {
fill: ${euiTheme.colors.textDisabled};
}
}
`,
selected: css`
background-color: ${hasVisColorAdjustment
background-color: ${hasVisColorAdjustment
? euiTheme.components.keyPadMenuItemBackgroundDisabledSelect
: euiTheme.colors.backgroundBaseDisabled};
`,
`,
},
};
};
Expand Down