Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiFormRow] Remove display="columnCompressedSwitch" prop option #8113

Merged
merged 3 commits into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not remove deprecated rowCompressed, but add more documentation …
…around it

+ remove internal usage
  • Loading branch information
cee-chen committed Nov 13, 2024
commit ef2ad65b5e6d75d8e23fc067d077d0ecd7bfada9
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,6 @@ export const EuiColorPicker: FunctionComponent<EuiColorPickerProps> = ({
mode === 'secondaryInput' || secondaryInputDisplay !== 'none';
const inlineInput = showSecondaryInput && (
<EuiFormRow
display="rowCompressed"
isInvalid={isInvalid}
error={isInvalid ? colorErrorMessage : null}
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ export const euiFormRowStyles = (euiThemeContext: UseEuiTheme) => {
${logicalCSS('margin-top', euiTheme.size.base)}
}
`,
// No difference from the uncompressed row for this current theme AFAICT
// TODO: Deprecate prop
// No difference from the uncompressed row for the current EUI theme
get rowCompressed() {
return this.row;
},
Expand Down
3 changes: 2 additions & 1 deletion packages/eui/src/components/form/form_row/form_row.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ export const DISPLAYS = [
'center',
'centerCompressed',
/**
* @deprecated
* This currently does not affect styles/appearances
* in EUI's present primary theme, but may in the future.
*/
'rowCompressed',
] as const;
Expand Down