Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDataGrid] Various row height fixes #8025

Merged
merged 11 commits into from
Sep 19, 2024
Merged

[EuiDataGrid] Various row height fixes #8025

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e63fb84
[storybook] Update default EuiDataGrid args to more closely mimic pro…
cee-chen Sep 13, 2024
5ad3ee5
Add VRT regression test for bug
cee-chen Sep 13, 2024
41d4f77
Fix bug by using the undefined/default height type for `lineCount: 1`
cee-chen Sep 13, 2024
12964b2
[cleanup] Remove now-unnecessary EuiDataGridHeaderCells button unset
cee-chen Sep 13, 2024
735c537
[7897] Fix control column/checkbox vertical alignment when going from…
cee-chen Sep 14, 2024
12dec35
[storybook] fix custom row heights story + crashes
cee-chen Sep 14, 2024
a08b0f9
Fix bug with custom row heights lineCount
cee-chen Sep 14, 2024
0b9ef8a
[7811] Fix row heights not changing on `gridStyle` or `rowHeightsOpti…
cee-chen Sep 14, 2024
fdde820
Fix stale `cellPadding` updates/calculations
cee-chen Sep 14, 2024
4ccf3a1
changelog
cee-chen Sep 17, 2024
1f35ef5
[PR feedback] Fix `rowHeights` overrides not triggering a recalculation
cee-chen Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...sktop_Tabular_Content_EuiDataGrid_rowHeightsOptions_prop_Custom_Row_Heights.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...obile_Tabular_Content_EuiDataGrid_rowHeightsOptions_prop_Custom_Row_Heights.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 6 additions & 4 deletions packages/eui/src/components/datagrid/data_grid_row_heights.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,15 +93,16 @@ export const CustomRowHeights: Story = {
parameters: { controls: { include: ['rowHeights'] } },
args: {
rowHeights: {
2: 'auto',
3: 48,
4: {
1: 'auto',
2: 48,
3: {
height: 56,
},
5: {
4: {
lineCount: 2,
mgadewoll marked this conversation as resolved.
Show resolved Hide resolved
},
},
onChange: undefined,
},
render: (rowHeightsOptions) => (
<StatefulDataGrid {...storyArgs} rowHeightsOptions={rowHeightsOptions} />
Expand All @@ -112,6 +113,7 @@ export const CustomLineHeight: Story = {
parameters: { controls: { include: ['lineHeight'] } },
args: {
lineHeight: '40px',
onChange: undefined,
},
render: (rowHeightsOptions) => (
<StatefulDataGrid {...storyArgs} rowHeightsOptions={rowHeightsOptions} />
Expand Down