Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion] Convert EuiDataGrid toolbar control styles to Emotion (Part 2) #7997

Merged
merged 11 commits into from
Sep 5, 2024
Merged

[Emotion] Convert EuiDataGrid toolbar control styles to Emotion (Part 2) #7997

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
09e19f8
Convert controls toolbar styles
cee-chen Sep 1, 2024
8bd364b
Handle grid borders style
cee-chen Sep 4, 2024
c5493fa
[microperf] Make control button Emotion styles static
cee-chen Sep 1, 2024
d51373b
Delete `.euiDataGrid__controlScroll` CSS + Sass variable
cee-chen Sep 1, 2024
1bb2543
Convert column selector control to Emotion
cee-chen Sep 1, 2024
19633da
Convert sorting control to Emotion
cee-chen Sep 1, 2024
0bdf395
Convert keyboard shortcuts to Emotion
cee-chen Sep 1, 2024
2e3b8d3
Convert display selector width style
cee-chen Sep 1, 2024
6036bc1
Delete Sass files
cee-chen Sep 4, 2024
115c9f2
changelog
cee-chen Sep 4, 2024
052965f
Add stories + VRT for datagrid toolbar
cee-chen Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/eui/src/components/datagrid/controls/data_grid_toolbar.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,15 @@ export const euiDataGridToolbarStyles = ({ euiTheme }: UseEuiTheme) => {
gap: ${euiTheme.size.base};
${logicalCSS('padding-vertical', euiTheme.size.xs)}
background-color: ${euiTheme.colors.emptyShade};

.euiDataGrid--bordersHorizontal & {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Do we need a TODO comment for keeping track of this to be reverted?

Copy link
Member Author

@cee-chen cee-chen Sep 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be able to keep mental track of it! I'm not super worried either way, as the code works as-is, so even if I get hit by a bus tomorrow or we go with another direction for EuiDataGrid's Emotion conversion, this is fine to leave in the codebase.

${logicalCSS('border-bottom', euiTheme.border.thin)}
}

.euiDataGrid--bordersAll & {
border: ${euiTheme.border.thin};
background-color: ${euiTheme.colors.body};
}
`,
euiDataGrid__rightControls: css`
display: flex;
Expand Down