[EuiIcon] Add new expand glyphs #7875
Conversation
|
Code changes LGTM |
There was a problem hiding this comment.
Thanks for putting this together, @andreadelrio. The icons look great. Leaving some small comments/questions below for your review. Once those are addressed though, I think you're good to go. Approving now so I don't hold you up.
-
Pixel grid: The plus and minus vector shapes within the box don't rest perfectly on the pixel grid, which means they will be slightly blurry on displays without a high pixel density. I'm guessing this was done so that the icon itself can be perfectly centered in the viewport. Historically though, I think we've tended to give higher priority to the pixel grid rather than perfect alignment. Would offsetting the icon alignment by 1px be OK to achieve better grid alignment?
-
Guidelines for usage: Should we provide some guidance somewhere that instructs designers when/where/why to use these icons versus the arrow icons that we typically use for accordion-type expand/collapse behavior? Ideally, it would be good to proactively reduce the potential for inconsistency if possible.
Co-authored-by: Michael Marcialis <michael.l.marcialis@gmail.com>
Co-authored-by: Michael Marcialis <michael.l.marcialis@gmail.com>
|
@MichaelMarcialis thanks Michael for the feedback, I've addressed it. @cee-chen I have pushed my changes but for some reason the new ML icons Joana recently added got their |
|
Should be fixed now! |
|
buildkite test this |
💚 Build Succeeded
History
|
`v95.4.0` ⏩ `v95.5.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v95.5.0`](https://github.com/elastic/eui/releases/v95.5.0) - Added `minusInSquare` and `plusInSquare` glyphs to `EuiIcon`. ([#7875](elastic/eui#7875)) **Bug fixes** - Fixed `EuiSuperDatePicker` not correctly passing `refreshMinInterval` from the quick select popover ([#7905](elastic/eui#7905)) **CSS-in-JS conversions** - Converted `EuiSuperDatePicker`'s form control to Emotion; ([#7904](elastic/eui#7904)) - Removed `$euiSuperDatePickerWidth` - Removed `$euiSuperDatePickerButtonWidth` - Removed `$euiSuperDatePickerNeedsUpdatingBackgroundColor` - Removed `$euiSuperDatePickerNeedsUpdatingTextColor` - Removed `@euiSuperDatePickerText` mixin - Converted `EuiSuperDatePicker`'s date popover content to Emotion ([#7908](elastic/eui#7908)) - Converted `EuiSuperDatePicker`'s quick select to Emotion ([#7909](elastic/eui#7909)) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Summary
Added the following new icon glyphs for use in [Discover][DocViewer] Limit the height of long field values by default #183736:
minusInSquareplusInSquareQA
Remove or strikethrough items that do not apply to your PR.
General checklist