[EuiStat] Accessibility - removed aria-hidden=true attribute
#7864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview staging links for this PR:
|
cee-chen
reviewed
Jul 1, 2024
1Copenut
reviewed
Jul 1, 2024
There was a problem hiding this comment.
I tested this briefly on my local machine and feel it's a better overall solution than consolidating the two text nodes using aria-hidden. VoiceOver announced each section as expected, and the visual cursor remained on the screen.
I'll leave the final code approval to @cee-chen but wanted to give an accessibility road-test comment to be part of the record.
it means JS doesn't have to instantiate a new reference
- memoize styles - use `useMemo` for JSX elements - remove `Fragment` - some code reordering
cee-chen
approved these changes
Jul 5, 2024
💚 Build Succeeded
History
|
cee-chen
pushed a commit
to elastic/kibana
that referenced
this pull request
Jul 25, 2024
`v95.3.0` ⏩ `v95.4.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v95.4.0`](https://github.com/elastic/eui/releases/v95.4.0) - Added `anomalyChart`, `anomalySwimLane`, `changePointDetection`, `fieldStatistics`, `logPatternAnalysis`, `logRateAnalysis` and `singleMetricViewer` glyph to `EuiIcon` ([#7873](elastic/eui#7873)) **Bug fixes** - Fixed overlapping content in `EuiBasicTable` for expanded and selectable table rows ([#7895](elastic/eui#7895)) - Fixed the alignment of `EuiBasicTable` mobile actions ([#7895](elastic/eui#7895)) **Accessibility** - Improved `EuiStat`'s screen reader accessibility ([#7864](elastic/eui#7864)) --- ## Additional Changes - reverts temporary fix for overlapping content in nested tables done in PR [#188374](#188374) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/elastic/observability-dev/issues/3630
Closes: https://github.com/elastic/observability-dev/issues/3634
Closes: https://github.com/elastic/observability-dev/issues/3633
Closes: https://github.com/elastic/observability-dev/issues/3632
Closes: https://github.com/elastic/observability-dev/issues/3631
Summary:
EuiStatby removing extraaria-hidden=trueattributeeui-screen-reader