Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion] Convert EuiColorPalettePicker and EuiColorPaletteDisplay #7854

Merged
merged 10 commits into from
Jun 27, 2024
Merged

[Emotion] Convert EuiColorPalettePicker and EuiColorPaletteDisplay #7854

merged 10 commits into from
Jun 27, 2024

Commits on Jun 26, 2024

  1. [EuiColorPalettePicker] Convert Sass to components 

    - doesn't need CSS at all! whoa!
    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e8256d5 View commit details
    Browse the repository at this point in the history

  2. [EuiColorPalettePicker] Optional performance/memoization

    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    cf4298b View commit details
    Browse the repository at this point in the history

  3. [EuiColorPalettePicker] Update tests/snapshots 

    - convert Enzyme to RTL + snapshot the popover
    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3bd8992 View commit details
    Browse the repository at this point in the history

  4. [EuiColorPaletteDisplay] Set up Emotion file

    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ef960b6 View commit details
    Browse the repository at this point in the history

  5. [EuiColorPaletteDisplay] Convert pseudo border CSS 

    - remove need for passing a size to by simply using the `inherit` CSS property
- remove mixin

- ignore light/dark arg, appears to be unused
    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    bc4d244 View commit details
    Browse the repository at this point in the history

  6. [EuiColorPaletteDisplay] Convert sizes 

    - remove modifier maps, no Kibana usages

- remove Sass variables

- remove unnecessary nested bleed area height CSS by inheriting `height: 100%` from the parent
    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    67175a3 View commit details
    Browse the repository at this point in the history

  7. [EuiColorPaletteDisplayFixed] Convert to Emotion 

    - can be a static const, no EUI variables being used

- switch to position inset of height/width for simplicity

- it's unclear if the 1px offset/workaround is due to an actual EUI var so I'm leaving it as a static 1px
    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    118c3c1 View commit details
    Browse the repository at this point in the history

  8. [EuiColorPaletteDisplay] Delete Sass files + update tests/snapshots

    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    0f8a62c View commit details
    Browse the repository at this point in the history

  9. changelog

    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    54f69dc View commit details
    Browse the repository at this point in the history

  10. [PR feedback] Make Storybook props table work again?

    @cee-chen
    cee-chen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    29a4697 View commit details
    Browse the repository at this point in the history