Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiBadge] Increase color contrast of selected text (+ bonus cleanup) #7752

Merged
merged 4 commits into from
May 16, 2024
Merged

[EuiBadge] Increase color contrast of selected text (+ bonus cleanup) #7752

merged 4 commits into from
May 16, 2024

Commits on May 13, 2024

  1. Convert EuiBadges to setting colors via color variable 

    + invert those colors for `::selection` text
    @cee-chen
    cee-chen committed May 13, 2024
    Configuration menu
    Copy the full SHA
    ce30100 View commit details
    Browse the repository at this point in the history

  2. Update storybook stories + add VRT

    @cee-chen
    cee-chen committed May 13, 2024
    Configuration menu
    Copy the full SHA
    013f7d5 View commit details
    Browse the repository at this point in the history

  3. [refactor] Clean up disabled styles 

    + fix low contrast selection color on disabled badges

- skip inline style custom colors completely if disabled, no need to calculate or apply them. this allows us to remove `!important` CSS

- skip other named colors as well, also no need to apply them. and clickable styles, that definitely makes no sense
    @cee-chen
    cee-chen committed May 13, 2024
    Configuration menu
    Copy the full SHA
    ce0d58d View commit details
    Browse the repository at this point in the history

  4. changelog

    @cee-chen
    cee-chen committed May 13, 2024
    Configuration menu
    Copy the full SHA
    79f0858 View commit details
    Browse the repository at this point in the history