Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDatePicker] Add screenreader-only calendar week day labels #7748

Merged
merged 17 commits into from
May 20, 2024
Merged

[EuiDatePicker] Add screenreader-only calendar week day labels #7748

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1317774
refactor(EuiDatePicker): add sr-only week names
mgadewoll May 13, 2024
b795391
test: update tests
mgadewoll May 13, 2024
85b300f
docs(Storybook): add EuiDatePicker playground story
mgadewoll May 13, 2024
8640f81
test(VRT): add reference images
mgadewoll May 13, 2024
3b146d6
chore: add changelog
mgadewoll May 13, 2024
4a17878
Merge branch 'main' into datepicker/5937-sr-only-header-text
mgadewoll May 13, 2024
f66e065
refactor(EuiDatePicker): add lont-text week day names only for englis…
mgadewoll May 14, 2024
a22fe90
test: add unit test for calendar week day names
mgadewoll May 14, 2024
e258b29
chore: cleanup
mgadewoll May 14, 2024
916a08d
chore: update changelog
mgadewoll May 14, 2024
5ca6ff7
refactor: simplify to use an array for the week day names map
mgadewoll May 14, 2024
d55580a
chore: add comment
mgadewoll May 14, 2024
5da213d
refactor: simplify locale usage by using moment locales instead
mgadewoll May 14, 2024
1098b86
test: update tests
mgadewoll May 14, 2024
52fdd83
refactor(EuiDatePicker): use moment weekdays API to retrieve long-tex…
mgadewoll May 15, 2024
4bbcbd9
test: remove added tests as they are obsolete now
mgadewoll May 15, 2024
30c324e
chore: update changelog
mgadewoll May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added packages/eui/.loki/reference/chrome_desktop_Forms_EuiDatePicker_Playground.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added packages/eui/.loki/reference/chrome_mobile_Forms_EuiDatePicker_Playground.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions packages/eui/changelogs/upcoming/7748.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
**Accessibility**

- Improved the accessibility of `EuiDatePicker` by providing sr-only full-text week day names to the calendar header for english locale
mgadewoll marked this conversation as resolved.
Show resolved Hide resolved

56 changes: 42 additions & 14 deletions packages/eui/src/components/date_picker/__snapshots__/date_picker.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,37 +87,51 @@ exports[`EuiDatePicker localization accepts the locale prop 1`] = `
<div
class="react-datepicker__day-name"
>
일
<span>
일
</span>
</div>
<div
class="react-datepicker__day-name"
>
월
<span>
월
</span>
</div>
<div
class="react-datepicker__day-name"
>
화
<span>
화
</span>
</div>
<div
class="react-datepicker__day-name"
>
수
<span>
수
</span>
</div>
<div
class="react-datepicker__day-name"
>
목
<span>
목
</span>
</div>
<div
class="react-datepicker__day-name"
>
금
<span>
금
</span>
</div>
<div
class="react-datepicker__day-name"
>
토
<span>
토
</span>
</div>
</div>
</div>
Expand Down Expand Up @@ -490,37 +504,51 @@ exports[`EuiDatePicker localization inherits locale from context 1`] = `
<div
class="react-datepicker__day-name"
>
lu
<span>
lu
</span>
</div>
<div
class="react-datepicker__day-name"
>
ma
<span>
ma
</span>
</div>
<div
class="react-datepicker__day-name"
>
me
<span>
me
</span>
</div>
<div
class="react-datepicker__day-name"
>
je
<span>
je
</span>
</div>
<div
class="react-datepicker__day-name"
>
ve
<span>
ve
</span>
</div>
<div
class="react-datepicker__day-name"
>
sa
<span>
sa
</span>
</div>
<div
class="react-datepicker__day-name"
>
di
<span>
di
</span>
</div>
</div>
</div>
Expand Down
154 changes: 140 additions & 14 deletions packages/eui/src/components/date_picker/__snapshots__/date_picker_range.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,37 +351,100 @@ exports[`EuiDatePickerRange props inline renders 1`] = `
<div
class="react-datepicker__day-name"
>
Su
<span
aria-hidden="true"
>
Su
</span>
<span
class="emotion-euiScreenReaderOnly"
>
Sunday
</span>
</div>
<div
class="react-datepicker__day-name"
>
Mo
<span
aria-hidden="true"
>
Mo
</span>
<span
class="emotion-euiScreenReaderOnly"
>
Monday
</span>
</div>
<div
class="react-datepicker__day-name"
>
Tu
<span
aria-hidden="true"
>
Tu
</span>
<span
class="emotion-euiScreenReaderOnly"
>
Tuesday
</span>
</div>
<div
class="react-datepicker__day-name"
>
We
<span
aria-hidden="true"
>
We
</span>
<span
class="emotion-euiScreenReaderOnly"
>
Wednesday
</span>
</div>
<div
class="react-datepicker__day-name"
>
Th
<span
aria-hidden="true"
>
Th
</span>
<span
class="emotion-euiScreenReaderOnly"
>
Thursday
</span>
</div>
<div
class="react-datepicker__day-name"
>
Fr
<span
aria-hidden="true"
>
Fr
</span>
<span
class="emotion-euiScreenReaderOnly"
>
Friday
</span>
</div>
<div
class="react-datepicker__day-name"
>
Sa
<span
aria-hidden="true"
>
Sa
</span>
<span
class="emotion-euiScreenReaderOnly"
>
Saturday
</span>
</div>
</div>
</div>
Expand Down Expand Up @@ -801,37 +864,100 @@ exports[`EuiDatePickerRange props inline renders 1`] = `
<div
class="react-datepicker__day-name"
>
Su
<span
aria-hidden="true"
>
Su
</span>
<span
class="emotion-euiScreenReaderOnly"
>
Sunday
</span>
</div>
<div
class="react-datepicker__day-name"
>
Mo
<span
aria-hidden="true"
>
Mo
</span>
<span
class="emotion-euiScreenReaderOnly"
>
Monday
</span>
</div>
<div
class="react-datepicker__day-name"
>
Tu
<span
aria-hidden="true"
>
Tu
</span>
<span
class="emotion-euiScreenReaderOnly"
>
Tuesday
</span>
</div>
<div
class="react-datepicker__day-name"
>
We
<span
aria-hidden="true"
>
We
</span>
<span
class="emotion-euiScreenReaderOnly"
>
Wednesday
</span>
</div>
<div
class="react-datepicker__day-name"
>
Th
<span
aria-hidden="true"
>
Th
</span>
<span
class="emotion-euiScreenReaderOnly"
>
Thursday
</span>
</div>
<div
class="react-datepicker__day-name"
>
Fr
<span
aria-hidden="true"
>
Fr
</span>
<span
class="emotion-euiScreenReaderOnly"
>
Friday
</span>
</div>
<div
class="react-datepicker__day-name"
>
Sa
<span
aria-hidden="true"
>
Sa
</span>
<span
class="emotion-euiScreenReaderOnly"
>
Saturday
</span>
</div>
</div>
</div>
Expand Down
Loading
Loading