Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiIcon] Remove logic that applies aria-hidden to empty/loading icons; [EuiIconTip] Fix non-i18n'd default aria-label #7606

Merged
merged 3 commits into from
Mar 20, 2024
Merged

[EuiIcon] Remove logic that applies aria-hidden to empty/loading icons; [EuiIconTip] Fix non-i18n'd default aria-label #7606

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48b8350
Do not apply `aria-hidden` to empty icons
cee-chen Mar 20, 2024
65f24f8
changelog
cee-chen Mar 20, 2024
a2816f7
[EuiIconTip] Fix non-i18n'd aria-label
cee-chen Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changelog
  • Loading branch information
@cee-chen
cee-chen committed Mar 20, 2024
commit 65f24f82c5a054a14ec3bcea127c1a8767955ab6
3 changes: 3 additions & 0 deletions changelogs/upcoming/7606.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Accessibility**

- `EuiIcons` no longer apply `aria-hidden` to empty icons, as long as a valid title or label is provided to the icon. In particular, this is intended to improve the accessibility of loading `EuiIconTip`s.