Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech debt] Create new internal util for rendering semantic <a>/<button> elements #7533

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Feb 15, 2024

Summary

This is a setup PR.

NOTE: No functional output DOM should have changed as a result of this PR, it's purely meant to DRY out repetitive logic and help clean up confusing types as a result.

QA

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
      - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA - N/A
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist - N/A

- all logic is related to links, and I'm shortly about to add some DRY logic that is link adjacent but not security adjacent that will use these utils, so it feels like it makes sense to group them all together
- and update component imports
- gets slightly messed by the new component, we need to semi-brute-force it
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Copy link

👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@cee-chen
Copy link
Member Author

🙈 Still working on this, I want to pick it back up after the Emotion meta

Copy link

👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@cee-chen
Copy link
Member Author

Someday......

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants