Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiFilterButton] DOM text wrapper cleanup #7444

Merged
merged 4 commits into from
Jan 5, 2024
Merged

[EuiFilterButton] DOM text wrapper cleanup #7444

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb5c493
[EuiFilterButton] Clean up DOM/CSS by disabling text wrapper
cee-chen Jan 3, 2024
9ed308d
Update downstream snapshots
cee-chen Jan 3, 2024
563252e
changelog
cee-chen Jan 3, 2024
9578d50
Fix regression in min-width behavior
cee-chen Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update downstream snapshots
  • Loading branch information
@cee-chen
cee-chen committed Jan 3, 2024
commit 9ed308dc59c4a6607c06eb485aebefae8ffbce09
24 changes: 8 additions & 16 deletions src/components/search_bar/__snapshots__/search_bar.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,15 +145,11 @@ exports[`SearchBar render - provided query, filters 1`] = `
class="euiButtonEmpty__content emotion-euiButtonDisplayContent-euiFilterButton__content"
>
<span
class="eui-textTruncate euiButtonEmpty__text euiFilterButton__text emotion-euiFilterButton__text"
class="euiFilterButton__text emotion-euiFilterButton__text"
data-text="Open"
title="Open"
>
<span
class="euiFilterButton__textShift emotion-euiFilterButton__textShift"
data-text="Open"
title="Open"
>
Open
</span>
Open
</span>
</span>
</button>
Expand All @@ -168,15 +164,11 @@ exports[`SearchBar render - provided query, filters 1`] = `
class="euiButtonEmpty__content emotion-euiButtonDisplayContent-euiFilterButton__content-hasIcon"
>
<span
class="eui-textTruncate euiButtonEmpty__text euiFilterButton__text emotion-euiFilterButton__text"
class="euiFilterButton__text emotion-euiFilterButton__text"
data-text="Tag"
title="Tag"
>
<span
class="euiFilterButton__textShift emotion-euiFilterButton__textShift"
data-text="Tag"
title="Tag"
>
Tag
</span>
Tag
</span>
<span
color="inherit"
Expand Down
24 changes: 8 additions & 16 deletions src/components/search_bar/__snapshots__/search_filters.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,11 @@ exports[`EuiSearchBarFilters render - with filters 1`] = `
class="euiButtonEmpty__content emotion-euiButtonDisplayContent-euiFilterButton__content"
>
<span
class="eui-textTruncate euiButtonEmpty__text euiFilterButton__text emotion-euiFilterButton__text"
class="euiFilterButton__text emotion-euiFilterButton__text"
data-text="Open"
title="Open"
>
<span
class="euiFilterButton__textShift emotion-euiFilterButton__textShift"
data-text="Open"
title="Open"
>
Open
</span>
Open
</span>
</span>
</button>
Expand All @@ -42,15 +38,11 @@ exports[`EuiSearchBarFilters render - with filters 1`] = `
class="euiButtonEmpty__content emotion-euiButtonDisplayContent-euiFilterButton__content-hasIcon"
>
<span
class="eui-textTruncate euiButtonEmpty__text euiFilterButton__text emotion-euiFilterButton__text"
class="euiFilterButton__text emotion-euiFilterButton__text"
data-text="Tag"
title="Tag"
>
<span
class="euiFilterButton__textShift emotion-euiFilterButton__textShift"
data-text="Tag"
title="Tag"
>
Tag
</span>
Tag
</span>
<span
color="inherit"
Expand Down
48 changes: 16 additions & 32 deletions src/components/search_bar/filters/__snapshots__/field_value_toggle_filter.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,11 @@ exports[`FieldValueToggleFilter render - active 1`] = `
class="euiButtonEmpty__content emotion-euiButtonDisplayContent-euiFilterButton__content"
>
<span
class="eui-textTruncate euiButtonEmpty__text euiFilterButton__text emotion-euiFilterButton__text"
class="euiFilterButton__text emotion-euiFilterButton__text"
data-text="Kibana"
title="Kibana"
>
<span
class="euiFilterButton__textShift emotion-euiFilterButton__textShift"
data-text="Kibana"
title="Kibana"
>
Kibana
</span>
Kibana
</span>
</span>
</button>
Expand All @@ -34,15 +30,11 @@ exports[`FieldValueToggleFilter render - active negated - custom negated name 1`
class="euiButtonEmpty__content emotion-euiButtonDisplayContent-euiFilterButton__content"
>
<span
class="eui-textTruncate euiButtonEmpty__text euiFilterButton__text emotion-euiFilterButton__text"
class="euiFilterButton__text emotion-euiFilterButton__text"
data-text="Others"
title="Others"
>
<span
class="euiFilterButton__textShift emotion-euiFilterButton__textShift"
data-text="Others"
title="Others"
>
Others
</span>
Others
</span>
</span>
</button>
Expand All @@ -58,15 +50,11 @@ exports[`FieldValueToggleFilter render - active negated 1`] = `
class="euiButtonEmpty__content emotion-euiButtonDisplayContent-euiFilterButton__content"
>
<span
class="eui-textTruncate euiButtonEmpty__text euiFilterButton__text emotion-euiFilterButton__text"
class="euiFilterButton__text emotion-euiFilterButton__text"
data-text="Not Kibana"
title="Not Kibana"
>
<span
class="euiFilterButton__textShift emotion-euiFilterButton__textShift"
data-text="Not Kibana"
title="Not Kibana"
>
Not Kibana
</span>
Not Kibana
</span>
</span>
</button>
Expand All @@ -82,15 +70,11 @@ exports[`FieldValueToggleFilter renders 1`] = `
class="euiButtonEmpty__content emotion-euiButtonDisplayContent-euiFilterButton__content"
>
<span
class="eui-textTruncate euiButtonEmpty__text euiFilterButton__text emotion-euiFilterButton__text"
class="euiFilterButton__text emotion-euiFilterButton__text"
data-text="Kibana"
title="Kibana"
>
<span
class="euiFilterButton__textShift emotion-euiFilterButton__textShift"
data-text="Kibana"
title="Kibana"
>
Kibana
</span>
Kibana
</span>
</span>
</button>
Expand Down
48 changes: 16 additions & 32 deletions ...components/search_bar/filters/__snapshots__/field_value_toggle_group_filter.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,11 @@ exports[`TermToggleGroupFilter render - active 1`] = `
class="euiButtonEmpty__content emotion-euiButtonDisplayContent-euiFilterButton__content"
>
<span
class="eui-textTruncate euiButtonEmpty__text euiFilterButton__text emotion-euiFilterButton__text"
class="euiFilterButton__text emotion-euiFilterButton__text"
data-text="Kibana"
title="Kibana"
>
<span
class="euiFilterButton__textShift emotion-euiFilterButton__textShift"
data-text="Kibana"
title="Kibana"
>
Kibana
</span>
Kibana
</span>
</span>
</button>
Expand All @@ -34,15 +30,11 @@ exports[`TermToggleGroupFilter render - active negated - custom negated name 1`]
class="euiButtonEmpty__content emotion-euiButtonDisplayContent-euiFilterButton__content"
>
<span
class="eui-textTruncate euiButtonEmpty__text euiFilterButton__text emotion-euiFilterButton__text"
class="euiFilterButton__text emotion-euiFilterButton__text"
data-text="-Kibana"
title="-Kibana"
>
<span
class="euiFilterButton__textShift emotion-euiFilterButton__textShift"
data-text="-Kibana"
title="-Kibana"
>
-Kibana
</span>
-Kibana
</span>
</span>
</button>
Expand All @@ -58,15 +50,11 @@ exports[`TermToggleGroupFilter render - active negated 1`] = `
class="euiButtonEmpty__content emotion-euiButtonDisplayContent-euiFilterButton__content"
>
<span
class="eui-textTruncate euiButtonEmpty__text euiFilterButton__text emotion-euiFilterButton__text"
class="euiFilterButton__text emotion-euiFilterButton__text"
data-text="Not Kibana"
title="Not Kibana"
>
<span
class="euiFilterButton__textShift emotion-euiFilterButton__textShift"
data-text="Not Kibana"
title="Not Kibana"
>
Not Kibana
</span>
Not Kibana
</span>
</span>
</button>
Expand All @@ -82,15 +70,11 @@ exports[`TermToggleGroupFilter renders 1`] = `
class="euiButtonEmpty__content emotion-euiButtonDisplayContent-euiFilterButton__content"
>
<span
class="eui-textTruncate euiButtonEmpty__text euiFilterButton__text emotion-euiFilterButton__text"
class="euiFilterButton__text emotion-euiFilterButton__text"
data-text="Kibana"
title="Kibana"
>
<span
class="euiFilterButton__textShift emotion-euiFilterButton__textShift"
data-text="Kibana"
title="Kibana"
>
Kibana
</span>
Kibana
</span>
</span>
</button>
Expand Down
12 changes: 4 additions & 8 deletions src/components/search_bar/filters/__snapshots__/is_filter.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,11 @@ exports[`IsFilter render 1`] = `
class="euiButtonEmpty__content emotion-euiButtonDisplayContent-euiFilterButton__content"
>
<span
class="eui-textTruncate euiButtonEmpty__text euiFilterButton__text emotion-euiFilterButton__text"
class="euiFilterButton__text emotion-euiFilterButton__text"
data-text="Open"
title="Open"
>
<span
class="euiFilterButton__textShift emotion-euiFilterButton__textShift"
data-text="Open"
title="Open"
>
Open
</span>
Open
</span>
</span>
</button>
Expand Down
Loading