Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiInlineEdit] Allow EuiInlineEdit to be used as a controlled component #7157

Merged
merged 13 commits into from
Sep 8, 2023

Commits on Aug 25, 2023

  1. Configuration menu
    Copy the full SHA
    39b7818 View commit details
    Browse the repository at this point in the history
  2. [EuiInlineEdit] Implement control logic

    - Created a DRY useMemo hook to handle switching/updating the value to be used in both read mode/edit mode and between controlled vs uncontrolled configurations
    - Replace readMode/editMode state variables with useMemo value
    - Pass new onChange & onCancel props to their respective functions within Inline Edit Form
    breehall committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    d3862c5 View commit details
    Browse the repository at this point in the history
  3. [EuiInlineEdit] Bug Fix & Cleanup

    - Remove the unnecessary passing of inline edit form props from EuiInlineEditText and EuiInlineEditTitle. These components we both importing props like defaultValue, placeholder, etc from InlineEditForm just send them back unchanged. The props transformed / changed within Text and Title remain while the others have been removed.
    - Spread {...rest} to the InlineEditForm container div. It was being passed by Text and Title, but was never used.
    - Updated snapshots to relflect the above change
    breehall committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    53d5b38 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. [EuiInlineEdit] Update the test cases for Inline Edit Form by creatin…

    …g a section dedicated to the props specific to creating a controlled component
    breehall committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    a643cc5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    08c5c30 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    977b3d5 View commit details
    Browse the repository at this point in the history
  4. Changelog

    breehall committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    c0f031c View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. [PR Feedback]

    - Inline Edit Text & Title - add the isReadOnly prop back (it was removed when refactoring these two child components by accident)
    - Architecture updates from PR feedback
    breehall committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    433ff26 View commit details
    Browse the repository at this point in the history
  2. [PR Feedback] Small update to documentation copy and example for usin…

    …g inline edit as a controlled component
    breehall committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    a0dedea View commit details
    Browse the repository at this point in the history
  3. [Test Updates]

    - Update unit tests to have more specific names and test assertions
    - Added an additional test for onSave validation
    breehall committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    627b33d View commit details
    Browse the repository at this point in the history
  4. [PR Feedback]

    - Add undefined fallback for placeholder for snapshot readability
    - Unit test copy and functionality updates
    breehall committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    a180fb1 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. [PR Feedback] Add comment explaining placeholder fallback. Update uni…

    …t test cases for clarity in functionality
    breehall committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    f98c6fb View commit details
    Browse the repository at this point in the history
  2. Changelog addition

    cee-chen authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    4bacd73 View commit details
    Browse the repository at this point in the history