Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiComboBox] Fix issue with duplicate checkmarks #4162

Merged
merged 5 commits into from
Oct 20, 2020
Merged

[EuiComboBox] Fix issue with duplicate checkmarks #4162

merged 5 commits into from
Oct 20, 2020

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Oct 20, 2020 •
edited
Loading

Summary

This fixes an issue that items inside a combo box with the same label (but different keys) will both look checked once one of them is marked:

screenshot-20201020-153309

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4162/

@timroes timroes added the bug label Oct 20, 2020
@timroes timroes marked this pull request as ready for review October 20, 2020 18:56
@timroes timroes mentioned this pull request Oct 20, 2020
Merged
1 task
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4162/

chandlerprall
chandlerprall approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, pulled & tested locally

@timroes timroes merged commit 1eff48a into elastic:master Oct 20, 2020
@timroes timroes deleted the fix/combo-box-key-issue branch October 20, 2020 19:53
@thompsongl thompsongl mentioned this pull request Oct 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timroes @kibanamachine @chandlerprall