[EuiInMemoryTable] Added ability to insert component between the searchbar and the table #4103
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test this |
|
@ashikmeerankutty thanks for taking this one on Ashik. How about updating the docs to show a use case for this new prop? Could maybe be an extra switch here, something like "Content between"
|
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4103/ |
|
@andreadelrio Thank you for your suggestion. Added an example usage for the new prop. Can you please verify ?. |
andreadelrio
left a comment
andreadelrio
left a comment
There was a problem hiding this comment.
@ashikmeerankutty thanks for adding the example. Sending one suggestion to improve it.
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4103/ |
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
One small request, otherwise this looks great!
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
LGTM! Pulled & tested locally. Thanks again @ashikmeerankutty !
…chbar and the table (elastic#4103) * Added childrenBetween prop * Add test for children between search and table * Updated snapshots * Updated comment for prop * Added cl * Add docs example for children between * Fixed a typo * Fixed text * Fixed issue when value is 0
4 participants
Summary
Fixes #4095
childrenBetweento add components between search bar and tableChecklist
- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples