Skip to content

Commit

Permalink
[PR feedback] Use non-invisible characters to reduce likelihood of co…
Browse files Browse the repository at this point in the history 
…nsumer

+ use 2 characters for increased chances

+ add more `data` attributes to help identify usages
  • Loading branch information
@cee-chen
cee-chen committed Sep 18, 2024
1 parent 729f192 commit 9a22861
Show file tree
Hide file tree
Showing 12 changed files with 163 additions and 138 deletions.
82 changes: 45 additions & 37 deletions packages/eui/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ exports[`EuiBasicTable actions custom item actions 1`] = `
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="newline"
>
↵
</span>
Expand All @@ -40,9 +40,9 @@ exports[`EuiBasicTable renders (bare-bones) 1`] = `
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="boundary"
>
⁣
𐘂𐘂
</span>
<table
class="euiTable emotion-euiTable-fixed-uncompressed-desktop"
Expand All @@ -54,13 +54,17 @@ exports[`EuiBasicTable renders (bare-bones) 1`] = `
>
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="no-copy"
>
⁢
✄𐘗
</span>
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="no-copy"
>
⁢
✄𐘗
</span>
</caption>
<thead>
Expand Down Expand Up @@ -89,7 +93,7 @@ exports[`EuiBasicTable renders (bare-bones) 1`] = `
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="newline"
>
↵
</span>
Expand Down Expand Up @@ -117,7 +121,7 @@ exports[`EuiBasicTable renders (bare-bones) 1`] = `
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="newline"
>
↵
</span>
Expand All @@ -141,7 +145,7 @@ exports[`EuiBasicTable renders (bare-bones) 1`] = `
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="newline"
>
↵
</span>
Expand All @@ -165,7 +169,7 @@ exports[`EuiBasicTable renders (bare-bones) 1`] = `
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="newline"
>
↵
</span>
Expand All @@ -176,9 +180,9 @@ exports[`EuiBasicTable renders (bare-bones) 1`] = `
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="boundary"
>
⁣
𐘂𐘂
</span>
</div>
`;
Expand All @@ -190,9 +194,9 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="boundary"
>
⁣
𐘂𐘂
</span>
<table
class="euiTable emotion-euiTable-fixed-uncompressed-desktop"
Expand All @@ -204,13 +208,17 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
>
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="no-copy"
>
⁢
✄𐘗
</span>
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="no-copy"
>
⁢
✄𐘗
</span>
</caption>
<thead>
Expand Down Expand Up @@ -246,7 +254,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="tab"
>
↦
</span>
Expand Down Expand Up @@ -286,7 +294,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="tab"
>
↦
</span>
Expand Down Expand Up @@ -315,7 +323,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="tab"
>
↦
</span>
Expand Down Expand Up @@ -344,7 +352,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="tab"
>
↦
</span>
Expand All @@ -367,7 +375,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="newline"
>
↵
</span>
Expand Down Expand Up @@ -410,7 +418,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="tab"
>
↦
</span>
Expand All @@ -426,7 +434,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="tab"
>
↦
</span>
Expand All @@ -446,7 +454,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="tab"
>
↦
</span>
Expand All @@ -466,7 +474,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="tab"
>
↦
</span>
Expand Down Expand Up @@ -517,7 +525,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="newline"
>
↵
</span>
Expand Down Expand Up @@ -556,7 +564,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="tab"
>
↦
</span>
Expand All @@ -572,7 +580,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="tab"
>
↦
</span>
Expand All @@ -592,7 +600,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="tab"
>
↦
</span>
Expand All @@ -612,7 +620,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="tab"
>
↦
</span>
Expand Down Expand Up @@ -663,7 +671,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="newline"
>
↵
</span>
Expand Down Expand Up @@ -702,7 +710,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="tab"
>
↦
</span>
Expand All @@ -718,7 +726,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="tab"
>
↦
</span>
Expand All @@ -738,7 +746,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="tab"
>
↦
</span>
Expand All @@ -758,7 +766,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="tab"
>
↦
</span>
Expand Down Expand Up @@ -809,7 +817,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="newline"
>
↵
</span>
Expand Down Expand Up @@ -884,9 +892,9 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<span
aria-hidden="true"
class="euiScreenReaderOnly"
data-tabular-copy-marker="true"
data-tabular-copy-marker="boundary"
>
⁣
𐘂𐘂
</span>
<div>
<div
Expand Down
Loading

0 comments on commit 9a22861

Please sign in to comment.