Merged
Conversation
sddonne
commented
Feb 24, 2026
| */ | ||
|
|
||
| export type * from './types'; | ||
| export type { VisitorMethods } from './types'; |
Contributor
Author
There was a problem hiding this comment.
Only VisitorMethods to not pollute the exports with all the types.
sddonne
commented
Feb 24, 2026
|
|
||
| export const isParametrized = (node: ESQLProperNode): boolean => Walker.params(node).length > 0; | ||
|
|
||
| const isESQLAstBaseItem = (node: unknown): node is types.ESQLAstBaseItem => |
Contributor
Author
There was a problem hiding this comment.
These 3 were declared in src/types.ts, better if we leave that file only for types.
sddonne
commented
Feb 24, 2026
| export { PromQLBuilder } from './ast/builder'; | ||
| export type { PromQLAstNodeTemplate } from './ast/builder/types'; | ||
|
|
||
| // Walker |
Contributor
Author
There was a problem hiding this comment.
Walker was not exposed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modify type exports.
Details
Now the main types are imported from "@elastic/esql/types".
Some tools like Walker and Visitor are now being exposed.