[TESTING] Remove redundant testing, define adapter

elastic · Sep 11, 2024 · 9e0b703 · 9e0b703
1 parent 549b827
commit 9e0b703
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 32 deletions.
diff --git a/spec/enterprise-search/client_spec.rb b/spec/enterprise-search/client_spec.rb
@@ -109,28 +109,12 @@ def messages; @strio.string; end
     let(:client) { described_class.new }
     let(:adapter) { client.transport.transport.connections.all.first.connection.builder.adapter }
 
-    context 'when no adapter is specified' do
-      it 'uses Faraday NetHttp' do
-        expect(adapter).to eq Faraday::Adapter::NetHttp
-      end
-    end
-
     context 'when the adapter is patron' do
       let(:client) { described_class.new(adapter: :patron) }
 
       it 'uses Faraday with the adapter' do
         expect(adapter).to eq Faraday::Adapter::Patron
       end
     end
-
-    unless defined?(JRUBY_VERSION)
-      context 'when the adapter is typhoeus' do
-        let(:client) { described_class.new(adapter: :patron) }
-
-        it 'uses Faraday with the adapter' do
-          expect(adapter).to eq Faraday::Adapter::Patron
-        end
-      end
-    end
   end
 end
diff --git a/spec/integration/app-search/app_search_helper.rb b/spec/integration/app-search/app_search_helper.rb
@@ -18,6 +18,7 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
+require 'faraday/patron'
 require 'logger'
 
 # App Search Integration tests Client Configuration

diff --git a/spec/integration/enterprise_search_api_spec.rb b/spec/integration/enterprise_search_api_spec.rb
@@ -18,6 +18,7 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
+require 'faraday/patron'
 
 describe Elastic::EnterpriseSearch::Client do
   let(:host) { ENV['ELASTIC_ENTERPRISE_HOST'] || 'http://localhost:3002' }

diff --git a/spec/integration/workplace-search/workplace_search_helper.rb b/spec/integration/workplace-search/workplace_search_helper.rb
@@ -18,6 +18,7 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
+require 'faraday/patron'
 
 # Workplace Search Integration tests Client Configuration
 def client

diff --git a/spec/workplace-search/client_spec.rb b/spec/workplace-search/client_spec.rb
@@ -101,28 +101,12 @@
     let(:client) { described_class.new }
     let(:adapter) { client.transport.transport.connections.all.first.connection.builder.adapter }
 
-    context 'when no adapter is specified' do
-      it 'uses Faraday NetHttp' do
-        expect(adapter).to eq Faraday::Adapter::NetHttp
-      end
-    end
-
     context 'when the adapter is patron' do
       let(:client) { described_class.new(adapter: :patron) }
 
       it 'uses Faraday with the adapter' do
         expect(adapter).to eq Faraday::Adapter::Patron
       end
     end
-
-    unless defined?(JRUBY_VERSION)
-      context 'when the adapter is typhoeus' do
-        let(:client) { described_class.new(adapter: :patron) }
-
-        it 'uses Faraday with the adapter' do
-          expect(adapter).to eq Faraday::Adapter::Patron
-        end
-      end
-    end
   end
 end