Skip to content

Conversation

@intxgo
Copy link
Contributor

@intxgo intxgo commented Jun 4, 2025

Change Summary

Global artifacts are rolled out gradually, only a selected few endpoints receive candidate artifacts to verify them before the rollout will progress. This PR adds global artifacts manifest type field to indicate which artifacts manifest type was currently used by the Endpoint.

Sample values

Endpoint using standard stable artifacts:
"Endpoint.policy.applied.artifacts.global.manifest_type": "stable"

Endpoint testing candidate artifacts:
"Endpoint.policy.applied.artifacts.global.manifest_type": "candidate"

Sample document:

Endpoint altert and Endpoint policy response:

{
    "Endpoint": {
        "policy": {
            "applied": {
                "artifacts": {
                    "global": {
                        "manifest_type": "stable",
                    },
}

Release Target

Q/A

For mapping changes:

  • I ran make after making the schema changes, and committed all changes
  • If these field(s) are "exception"-able, I made a companion PR to Kibana adding it (see Readme)
  • If this is a metadata change, I also updated both transform destination schemas to match

For Transform changes:

  • The new transform successfully starts in Kibana
  • The corresponding transform destination schema was updated if necessary

@intxgo intxgo requested review from a team as code owners June 4, 2025 08:34
@intxgo intxgo requested review from joeypoon and parkiino June 4, 2025 08:34
- Endpoint.metrics.queue_metrics.kernel.send_to_user_queue.drops
- Endpoint.metrics.queue_metrics.kernel.send_to_user_queue.size
- Endpoint.metrics.queue_metrics.kernel.send_to_user_queue.last_drop_time_utc
- Endpoint.metrics.queue_metrics.kernel.send_to_user_queue.size
Copy link
Contributor Author

@intxgo intxgo Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like some of the the custom documentation was modified manually, so the update script moved things around when sorting the updated filed

⚠️ custom documentation should be updated by script ideally (on Linux, as it's the only supported system for running make in endpoint-package repository). Updating it manually is not an error, but it leads to unexpected changes on other's PRs, such as unsorted fields

@intxgo intxgo enabled auto-merge (squash) June 4, 2025 09:00
@ashokaditya ashokaditya requested a review from pzl June 4, 2025 09:30
@intxgo intxgo merged commit d1bbf9f into main Jun 4, 2025
4 checks passed
@intxgo intxgo deleted the lesio/manifest_type branch June 4, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants